-
Notifications
You must be signed in to change notification settings - Fork 86
CI: Enable checkcommits #13
CI: Enable checkcommits #13
Conversation
Hi @jodh-intel , so we should open an issue before submitting a PR, wow about |
@liangchenye - currently, yes, you need an issue for all PRs. It's only a few clicks to create an issue and the idea is that you create the issue and get it assigned to yourself as soon as you start working on a change. That way, it's clear what is being worked on and by whom. This is important to keep track of "upcoming" features/fixes but also helps to avoid multiple people raising PRs for the same fix/feature. That scenario has actually happened more than once in Clear Containers! 😄 |
@jodh-intel thanks, I'll open an issue and submit again. |
f77f67e
to
3b5751b
Compare
Hi @jcvenegas - could you review please? |
Can you please rebase to pass CI now that #40 is merged? |
Require all PRs to contain a "Fixes #XXX" comment and a "Signed-off-by:" comment by running the central static checks script. Note that the static checks script will detect if the repository contains golang code and only run those checks if it does. Fixes kata-containers#12. Signed-off-by: James O. D. Hunt <[email protected]>
3b5751b
to
895aad1
Compare
Branch updated. |
For euleros, it has supported aarch64 starting from v2.3, but here is the sad part, there existed bugs in their 2.3.x image, this bug existed in both x86_64 and aarch64 image. related issue euleros/euleros-docker-images/kata-containers#13 (euleros/euleros-docker-images#13) has been raised. Fixes: kata-containers#320 Signed-off-by: Penny Zheng <[email protected]>
For euleros, it has supported aarch64 starting from v2.3, but here is the sad part, there existed bugs in their 2.3.x image, this bug existed in both x86_64 and aarch64 image. related issue euleros/euleros-docker-images/kata-containers#13 (euleros/euleros-docker-images#13) has been raised. Fixes: kata-containers#320 Signed-off-by: Penny Zheng <[email protected]>
For euleros, it has supported aarch64 starting from v2.3, but here is the sad part, there existed bugs in their 2.3.x image, this bug existed in both x86_64 and aarch64 image. related issue euleros/euleros-docker-images/kata-containers#13 (euleros/euleros-docker-images#13) has been raised. Fixes: kata-containers#320 Signed-off-by: Penny Zheng <[email protected]>
Require all PRs to contain a "Fixes #XXX" comment and a
"Signed-off-by:" comment.
Also necessitated adding a very minimal
.travis.yml
totrigger
checkcommits
.Fixes #12.
Signed-off-by: James O. D. Hunt [email protected]